Skip to content

ES|QL: fix join masking eval #126614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
27865d7
ES|QL: fix pre-analysis of JOIN masking EVAL
luigidellaquila Apr 10, 2025
0d35e21
Add capability
luigidellaquila Apr 10, 2025
08803dc
Fix test
luigidellaquila Apr 10, 2025
b820057
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 10, 2025
fc44c26
enable relevant paths in generative tests
luigidellaquila Apr 10, 2025
132c587
make tests deterministic
luigidellaquila Apr 10, 2025
dcc9e18
Update docs/changelog/126614.yaml
luigidellaquila Apr 10, 2025
fb205bd
Fix test
luigidellaquila Apr 10, 2025
3c1ccea
Merge remote-tracking branch 'luigidellaquila/esql/fix_join_masking_e…
luigidellaquila Apr 10, 2025
7d5d67b
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 11, 2025
812cbe8
Refactoring
luigidellaquila Apr 11, 2025
5f3b001
also Aggregate
luigidellaquila Apr 11, 2025
f2f0a3d
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 11, 2025
ae267ac
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 11, 2025
6720f9b
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 15, 2025
1a23c32
Refactor and add tests
luigidellaquila Apr 15, 2025
ab77736
Merge remote-tracking branch 'luigidellaquila/esql/fix_join_masking_e…
luigidellaquila Apr 15, 2025
cf4719d
Implement review suggestions
luigidellaquila Apr 15, 2025
ecb72e9
Fix typo
luigidellaquila Apr 15, 2025
d6fdb22
Comments
luigidellaquila Apr 15, 2025
e6f51bb
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 15, 2025
8744884
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila Apr 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into esql/fix_join_masking_eval
  • Loading branch information
luigidellaquila committed Apr 11, 2025
commit 7d5d67bc50bde3443e933e39b0eb4b432847545a
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,16 @@ public enum Cap {
*/
FORK_V2(Build.current().isSnapshot()),

/**
* Does the usage information for ESQL contain a histogram of {@code took} values?
*/
USAGE_CONTAINS_TOOK,

/**
* Support avg_over_time aggregation that gets evaluated per time-series
*/
AVG_OVER_TIME(Build.current().isSnapshot()),

/**
* During resolution (pre-analysis) we have to consider that joins can override EVALuated values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* During resolution (pre-analysis) we have to consider that joins can override EVALuated values
* During resolution (pre-analysis) we have to consider that joins or enriches can override EVALuated values

* https://github.com/elastic/elasticsearch/issues/126419
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.