-
Notifications
You must be signed in to change notification settings - Fork 25.3k
ES|QL: fix join masking eval #126614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luigidellaquila
merged 22 commits into
elastic:main
from
luigidellaquila:esql/fix_join_masking_eval
Apr 15, 2025
Merged
ES|QL: fix join masking eval #126614
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
27865d7
ES|QL: fix pre-analysis of JOIN masking EVAL
luigidellaquila 0d35e21
Add capability
luigidellaquila 08803dc
Fix test
luigidellaquila b820057
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila fc44c26
enable relevant paths in generative tests
luigidellaquila 132c587
make tests deterministic
luigidellaquila dcc9e18
Update docs/changelog/126614.yaml
luigidellaquila fb205bd
Fix test
luigidellaquila 3c1ccea
Merge remote-tracking branch 'luigidellaquila/esql/fix_join_masking_e…
luigidellaquila 7d5d67b
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila 812cbe8
Refactoring
luigidellaquila 5f3b001
also Aggregate
luigidellaquila f2f0a3d
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila ae267ac
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila 6720f9b
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila 1a23c32
Refactor and add tests
luigidellaquila ab77736
Merge remote-tracking branch 'luigidellaquila/esql/fix_join_masking_e…
luigidellaquila cf4719d
Implement review suggestions
luigidellaquila ecb72e9
Fix typo
luigidellaquila d6fdb22
Comments
luigidellaquila e6f51bb
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila 8744884
Merge branch 'main' into esql/fix_join_masking_eval
luigidellaquila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'main' into esql/fix_join_masking_eval
- Loading branch information
commit 7d5d67bc50bde3443e933e39b0eb4b432847545a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.