Skip to content

Update TestSparseInferenceServiceExtension to not support text embeddings #126618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Apr 10, 2025

Does what the title says. Fixes incorrect behavior introduced by #123044, which is wrong for a couple reasons:

  • A sparse embedding inference service should not support text embeddings
  • The text embedding generation implemented creates a random embedding for each call, which effectively makes it useless for most of our test cases. Many of our test cases rely on consistent result ordering, which won't happen if the embedding changes on subsequent calls with the same input. See generateEmbedding for how we generate a text embedding fit for purpose.

@Mikep86 Mikep86 added >non-issue :ml Machine learning auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Apr 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Apr 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikep86 Mikep86 merged commit 9956bed into elastic:main Apr 10, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants