Allow a tsdb data stream to rolled over to a logsdb data stream #126640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the other way around. This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to elastic#126637
martijnvg
added
>non-issue
:StorageEngine/TSDB
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
reviewed
Apr 10, 2025
| @@ -610,6 +610,10 @@ public DataStream unsafeRollover( | |||
| } else if (dsIndexMode == IndexMode.LOGSDB && (indexModeFromTemplate == null || indexModeFromTemplate == IndexMode.STANDARD)) { | |||
| // Allow downgrading a time series data stream to a regular data stream | |||
| dsIndexMode = null; | |||
| } else if (dsIndexMode == IndexMode.TIME_SERIES && indexModeFromTemplate == IndexMode.LOGSDB) { | |||
There was a problem hiding this comment.
Is dsIndexMode the index mode of the write index?
There was a problem hiding this comment.
It indicates whether a data stream is a tsdb data stream or a logsdb data stream. It isn't always the index mode of the most recent backing index, because the standard and lookup mode are never set as index mode of a data stream (there is no such thing as a lookup data stream). There is logic that checks the index mode (all checks are for time series iirc) of the data stream without having the to lookup the most recent IndexMetadata.
But if a data stream's index mode is logsdb or time series, then the most recent backing index's index mode should also be time series of logsdb.
kkrik-es
reviewed
Apr 11, 2025
| } else if (dsIndexMode == IndexMode.TIME_SERIES && indexModeFromTemplate == IndexMode.LOGSDB) { | ||
| dsIndexMode = IndexMode.LOGSDB; | ||
| } else if (dsIndexMode == IndexMode.LOGSDB && indexModeFromTemplate == IndexMode.TIME_SERIES) { | ||
| dsIndexMode = IndexMode.TIME_SERIES; |
There was a problem hiding this comment.
Should we be adding a warning too? Just in case this is done by mistake..
kkrik-es
approved these changes
Apr 11, 2025
martijnvg
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 11, 2025
and the other way around. Backporting elastic#126640 This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to elastic#126637
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 11, 2025
and the other way around. Backporting elastic#126640 This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to elastic#126637
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 11, 2025
and the other way around. Backporting elastic#126640 to 8.18 branch. This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to elastic#126637
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
#126714) * [8.18] Allow a tsdb data stream to rolled over to a logsdb data stream and the other way around. Backporting #126640 to 8.18 branch. This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to #126637 * fix test compile issue
martijnvg
added a commit
that referenced
this pull request
Apr 12, 2025
…#126712) Backporting #126640 to 9.0 branch. This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen. Related to #126637 * fix test compile issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and the other way around.
This doesn't make much sense. However, if a data stream's index mode differs from the index mode of most recent backing index, then this can cause confusion. Typically, misconfiguration is a reason this can happen.
Related to #126637