Skip to content

Dry up o.e.c.lucene.Lucene transport logic #126646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Dry up o.e.c.lucene.Lucene transport logic #126646

merged 1 commit into from
Apr 11, 2025

Conversation

original-brownbear
Copy link
Member

We've accumulated quited a bit of duplication here, drying this logic up a little.

@original-brownbear
Dry up o.e.c.lucene.Lucene transport logic
f7247e2 
We've accumulated quited a bit of duplication here, drying this logic up a little.
@original-brownbear original-brownbear added >non-issue :Search Foundations/Search Catch all for Search Foundations labels Apr 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.1.0 labels Apr 10, 2025
drempapis
drempapis approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maintenance work is important from time to time

@original-brownbear original-brownbear added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Apr 11, 2025
@original-brownbear
Copy link
Member Author

Thanks Dimitris!

@original-brownbear original-brownbear merged commit 55453ae into elastic:main Apr 11, 2025
17 checks passed
@original-brownbear original-brownbear deleted the dry-up-lucene-transport branch April 11, 2025 09:39
@original-brownbear original-brownbear mentioned this pull request Apr 11, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 11, 2025
@original-brownbear
Dry up o.e.c.lucene.Lucene transport logic (elastic#126646)
5e3c000 
We've accumulated quited a bit of duplication here, drying this logic up a little.
elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@original-brownbear
Dry up o.e.c.lucene.Lucene transport logic (#126646) (#126671)
277b2bb 
We've accumulated quited a bit of duplication here, drying this logic up a little.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drempapis drempapis drempapis approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged >non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@original-brownbear @elasticsearchmachine @drempapis