Expose merge events and their memory usage estimate #126667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
WIP
:Distributed Indexing/Engine
pxsalehi
force-pushed
the
ps250410-exposeMergeEvents
branch
from
11667b7 to
6fffd73
Compare
pxsalehi
force-pushed
the
ps250410-exposeMergeEvents
branch
from
6fffd73 to
643979c
Compare
pxsalehi
commented
Apr 22, 2025
There was a problem hiding this comment.
Moved this out of stateless.
elasticsearchmachine
added
the
serverless-linked
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
henningandersen
approved these changes
Apr 22, 2025
| @@ -449,6 +462,14 @@ long estimatedMergeSize() { | |||
| return onGoingMerge.getMerge().getStoreMergeInfo().estimatedMergeBytes(); | |||
| } | |||
|
|
|||
| public long getEstimateMergeMemoryBytes() { | |||
There was a problem hiding this comment.
nit: I'd prefer to call this getMergeMemoryEstimateBytes(), similar to the provider (also rename various variales).
|
I've added 3724a21 as a simple way to make sure abort/complete listeners are not called before queued listeners for a given merge. |
|
|
||
| private void enqueueMergeTask(MergeTask mergeTask) { | ||
| synchronized (mergeEventsMutex) { | ||
| if (queuedMergeTasks.add(mergeTask)) { |
There was a problem hiding this comment.
I think we can assert that it always returns true instead, thus avoid the if-statement, invoke the listener before adding and thus avoid the synchronized?
There was a problem hiding this comment.
Sure. See ba7ebb5. This doesn't change anything in the stateless PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates ES-10961