Test fix: align timeouts in testDataStreamLifecycleDownsampleRollingRestart (#123769)
#126682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
added
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 15, 2025
…Restart` (elastic#123769) (elastic#126682) Recently we changed the implementation of `testDataStreamLifecycleDownsampleRollingRestart` to use a temporary state listener. We missed that the listener also had a timeout that was quite shorter than the `safeGet` timeout we were configuring. In this PR we align these two timeouts. Fixes: elastic#123769 (cherry picked from commit e461717) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
…Restart` (#123769) (#126682) (#126816) Recently we changed the implementation of `testDataStreamLifecycleDownsampleRollingRestart` to use a temporary state listener. We missed that the listener also had a timeout that was quite shorter than the `safeGet` timeout we were configuring. In this PR we align these two timeouts. Fixes: #123769 (cherry picked from commit e461717) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
|
Manually backported to |
nielsbauman
pushed a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 18, 2025
…Restart` (elastic#123769) (elastic#126682) Recently we changed the implementation of `testDataStreamLifecycleDownsampleRollingRestart` to use a temporary state listener. We missed that the listener also had a timeout that was quite shorter than the `safeGet` timeout we were configuring. In this PR we align these two timeouts. Fixes: elastic#123769 (cherry picked from commit e461717) # Conflicts: # muted-tests.yml # x-pack/plugin/downsample/src/internalClusterTest/java/org/elasticsearch/xpack/downsample/DataStreamLifecycleDownsampleDisruptionIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 18, 2025
…Restart` (#123769) (#126682) (#127049) Recently we changed the implementation of `testDataStreamLifecycleDownsampleRollingRestart` to use a temporary state listener. We missed that the listener also had a timeout that was quite shorter than the `safeGet` timeout we were configuring. In this PR we align these two timeouts. Fixes: #123769 (cherry picked from commit e461717) # Conflicts: # muted-tests.yml # x-pack/plugin/downsample/src/internalClusterTest/java/org/elasticsearch/xpack/downsample/DataStreamLifecycleDownsampleDisruptionIT.java Co-authored-by: Mary Gouseti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we changed the implementation of
testDataStreamLifecycleDownsampleRollingRestartto use a temporary state listener. We missed that the listener also had a timeout that was quite shorter than thesafeGettimeout we were configuring. In this PR we align these two timeouts.Fixes: #123769