[CI] Fix IndexShardTests.testReentrantEngineReadLockAcquisitionInRefreshListener #126685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eshListener I suspect the test resets/closes the reference manager between the refresh and the retrieval of the segment generation after the refresh. By executing segmentGenerationAfterRefresh while holding the engine reset lock we make sure there are no concurrent engine resets meanwhile. In the future, we should also ensure that IndexShard.refresh() uses withEngine. Closes elastic#126628
tlrx
added
>test
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
arteam
approved these changes
Apr 11, 2025
tlrx
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect the test resets/closes the reference manager between the
refresh and the retrieval of the segment generation after the refresh.
By executing segmentGenerationAfterRefresh while holding the engine
reset lock we make sure there are no concurrent engine resets meanwhile.
In the future, we should also ensure that IndexShard.refresh() uses withEngine.
Closes #126628