Skip to content

Add dense vector off-heap stats to Node stats and Index stats APIs #126704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
27fbf93
initial changes to support dense vectors off-heap stats
ChrisHegarty Apr 11, 2025
ae423d9
Update docs/changelog/126704.yaml
ChrisHegarty Apr 11, 2025
9a1ab35
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 11, 2025
55d09e6
humanReadable
ChrisHegarty Apr 14, 2025
e22dcbc
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 14, 2025
fd78802
Merge remote-tracking branch 'chegar/dense_vector_stats' into dense_v…
ChrisHegarty Apr 14, 2025
dcf3765
changelog
ChrisHegarty Apr 14, 2025
e755931
test updates
ChrisHegarty Apr 14, 2025
bffb289
fix changelog
ChrisHegarty Apr 14, 2025
0a198b5
eagerly initialize OffHeapReflectionUtils
ChrisHegarty Apr 14, 2025
37e040d
fix test
ChrisHegarty Apr 15, 2025
d33d103
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 15, 2025
a7c50c8
test
ChrisHegarty Apr 15, 2025
609b42c
Merge branch 'main' into dense_vector_stats
elasticmachine Apr 15, 2025
87974cf
more test fixes
ChrisHegarty Apr 16, 2025
8ccfb80
Merge branch 'main' into dense_vector_stats
elasticmachine Apr 16, 2025
f0fce25
fix
ChrisHegarty Apr 16, 2025
18c6cce
Merge branch 'main' into dense_vector_stats
elasticmachine Apr 16, 2025
3188967
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 16, 2025
b67bc26
test fixes
ChrisHegarty Apr 16, 2025
5645d15
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 16, 2025
8e935a1
fix tv
ChrisHegarty Apr 16, 2025
cfb498c
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 17, 2025
505f2b4
do not override already set params
ChrisHegarty Apr 17, 2025
bd0d782
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 17, 2025
df1878a
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 17, 2025
4638377
add support for old codecs
ChrisHegarty Apr 18, 2025
86c79f9
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 18, 2025
38a5279
fix opens
ChrisHegarty Apr 18, 2025
40041b9
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 19, 2025
afddeff
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 20, 2025
3a006f4
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 20, 2025
6ac2bda
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 21, 2025
213c945
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 23, 2025
5fa98d7
Merge branch 'main' into dense_vector_stats
ChrisHegarty Apr 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ static List<String> systemJvmOptions(Settings nodeSettings, final Map<String, St
"-Dio.netty.noUnsafe=true",
"-Dio.netty.noKeySetOptimization=true",
"-Dio.netty.recycler.maxCapacityPerThread=0",
// temporary until we get off-heap vector stats in Lucene 10.3
"--add-opens=org.apache.lucene.core/org.apache.lucene.codecs.lucene99=org.elasticsearch.server",
"--add-opens=org.apache.lucene.backward_codecs/org.apache.lucene.backward_codecs.lucene90=org.elasticsearch.server",
"--add-opens=org.apache.lucene.backward_codecs/org.apache.lucene.backward_codecs.lucene91=org.elasticsearch.server",
"--add-opens=org.apache.lucene.backward_codecs/org.apache.lucene.backward_codecs.lucene92=org.elasticsearch.server",
"--add-opens=org.apache.lucene.backward_codecs/org.apache.lucene.backward_codecs.lucene94=org.elasticsearch.server",
"--add-opens=org.apache.lucene.backward_codecs/org.apache.lucene.backward_codecs.lucene95=org.elasticsearch.server",
// log4j 2
"-Dlog4j.shutdownHookEnabled=false",
"-Dlog4j2.disable.jmx=true",
Expand Down
5 changes: 5 additions & 0 deletions docs/changelog/126704.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 126704
summary: Add dense vector off-heap stats to Node stats and Index stats APIs
area: "Vector Search"
type: enhancement
issues: []
4 changes: 2 additions & 2 deletions qa/ccs-common-rest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ apply plugin: 'elasticsearch.internal-yaml-rest-test'

restResources {
restApi {
include 'capabilities', '_common', 'bulk', 'count', 'cluster', 'field_caps', 'get', 'knn_search', 'index', 'indices', 'msearch',
'search', 'async_search', 'graph', '*_point_in_time', 'info', 'scroll', 'clear_scroll', 'search_mvt', 'eql', 'sql'
include 'capabilities', 'cat.shards', '_common', 'bulk', 'count', 'cluster', 'field_caps', 'get', 'knn_search', 'index', 'indices', 'msearch',
"nodes.stats", 'search', 'async_search', 'graph', '*_point_in_time', 'info', 'scroll', 'clear_scroll', 'search_mvt', 'eql', 'sql'
}
restTests {
includeCore 'field_caps', 'msearch', 'search', 'suggest', 'scroll', "indices.resolve_index"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@
- match: { indices.docs.count: 5 }
- match: { indices.docs.deleted: 0 }
- match: { indices.dense_vector.value_count: 8 }
- is_false: indices.dense_vector.off_heap

---
"Sparse vector stats":
Expand Down
Loading
Loading