Correct the condition to use a multi field block loader in text field block loader #126718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
added
>non-issue
:Analytics/ES|QL
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
added
auto-backport
| @@ -967,12 +967,11 @@ public boolean isAggregatable() { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true if the delegate sub-field can be used for loading and querying (ie. either isIndexed or isStored is true) | |||
| * Returns true if the delegate sub-field can be used for loading. | |||
| * A delegate by definition must have doc_values or be stored so most of the time it can be used for loading. | |||
There was a problem hiding this comment.
Suggested change
| * A delegate by definition must have doc_values or be stored so most of the time it can be used for loading. | |
| * A delegate by definition must have doc_values or be stored so most of the time it can be used for querying. |
I think?
There was a problem hiding this comment.
There already is canUseSyntheticSourceDelegateForQuerying() so "loading" distinguishes the two.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current condition of
syntheticSourceDelegate.isIndexed() || syntheticSourceDelegate.isStored()seems to be stale.isStored()is always true forsyntheticSourceDelegateandisIndexed()is actually not needed for keyword block loader to work. This PR removes excessive conditions.