Skip to content

[8.x] ES|QL change point #126771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 15, 2025
Merged

[8.x] ES|QL change point #126771

merged 14 commits into from
Apr 15, 2025

Conversation

jan-elastic
Copy link
Contributor

This contains:

jan-elastic and others added 5 commits April 14, 2025 11:07
* Grammar for ES|QL change point (with dummy impl)

* pipeline breaker

* ChangePointOperator

* Add sorting

* basic csv test

* conflict

* Update docs/changelog/120998.yaml

* [CI] Auto commit changes from spotless

* polish

* Non-long data type

* Move OrderBy/Limit to the logical plan

* fix mem.leak

* csv test for reusing column names

* Warning indeterminable

* capability

* handle null values

* too much data

* type text->keyword

* default timestamp and output columns

* spotless

* ChangePointOperatorTests + fix memory leaks

* [CI] Auto commit changes from spotless

* improve test

* add comments/todos

* handle multivalued columns

* don't register unserialiazable

* surrogate

* make "too much data" tests readable

* more tests

* Error handling

* fix multivalued test

* more name conflict tests

* [CI] Auto commit changes from spotless

* more tests

* improve code

* CSV test for various input key/value types

* one more csv test

* Check sortable/numeric for all types

* add null type to testChangePoint_valueNumeric

* more CSV tests

* skip nulls instead of zeroing them

* error on MV

* Test+todo for nicer error message

* better error msg

* Revert "better error msg"

This reverts commit 21ec77c.

* fix

* make csv test deterministic

* replace NamedExpression -> Attribute

* skip MVs + warning

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.19.0 needs:triage Requires assignment of a team area label labels Apr 14, 2025
@jan-elastic jan-elastic added >feature backport Team:ML Meta label for the ML team :ml Machine learning and removed needs:triage Requires assignment of a team area label labels Apr 14, 2025
craigtaverner

This comment was marked as outdated.

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Note is including too much of the contents.

@jan-elastic
Copy link
Contributor Author

image

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-elastic jan-elastic merged commit f9fd055 into 8.x Apr 15, 2025
16 checks passed
@jan-elastic jan-elastic deleted the 8.x-esql-change-point branch April 15, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >feature :ml Machine learning Team:ML Meta label for the ML team v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants