Skip to content

Fix and unmute SemanticInferenceMetadataFieldsRecoveryTests #126784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Apr 14, 2025

Use the TranslogOperationAsserter to compare the raw operations.

Closes #124383
Closes #124384
Closes #124385

Use the TranslogOperationAsserter to compare the raw operations.

Closes elastic#124383
Closes elastic#124384
Closes elastic#124385
@jimczi jimczi added >test Issues or PRs that are addressing/adding tests :Search Relevance/Search Catch all for Search Relevance v8.19.0 v9.1.0 labels Apr 14, 2025
@jimczi jimczi requested a review from Mikep86 April 14, 2025 15:24
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we backport to 8.18/9.0 to fix the flaky tests there as well?

@jimczi jimczi added the auto-backport Automatically create backport pull requests when merged label Apr 15, 2025
@jimczi jimczi merged commit 46c3657 into elastic:main Apr 15, 2025
17 checks passed
@jimczi jimczi deleted the semantic_text_recovery_tests branch April 15, 2025 06:36
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126784

jimczi added a commit to jimczi/elasticsearch that referenced this pull request Apr 15, 2025
…126784)

Use the TranslogOperationAsserter to compare the raw operations.

Closes elastic#124383
Closes elastic#124384
Closes elastic#124385
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 16, 2025
…126784)

Use the TranslogOperationAsserter to compare the raw operations.

Closes elastic#124383
Closes elastic#124384
Closes elastic#124385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
3 participants