Revert endpoint creation validation for ELSER and E5 #126792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>bug
:ml
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
wwang500
added
the
cloud-deploy
|
@elasticmachine merge upstream |
jonathan-buttner
approved these changes
Apr 14, 2025
dan-rubinstein
added
the
auto-backport
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Revert endpoint creation validation for ELSER and E5 * Update docs/changelog/126792.yaml * Revert start model deployment being in TransportPutInferenceModelAction --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a preivous PR we added endpoint validation for ELSER, ELAND (non-text-embedding) and E5. As part of this change we moved the start model deployment call to before the validation call rather than after the endpoint has been created. It seems that the start deployment call will succeed before the model deployment has been assigned a node after which the validation call will fail. As a temporary solution this change will revert the validation logic so that only ELAND text embedding is being validated (as before). All other local model endpoints should not run validation.