Skip to content

Add unit tests for MountSnapshotStep in COLD phase #126804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Add unit tests for MountSnapshotStep in COLD phase #126804

merged 2 commits into from
Apr 14, 2025

Conversation

samxbr
Copy link
Contributor

@samxbr samxbr commented Apr 14, 2025

Adds unit tests to confirm total_shards_per_node is not ignored in COLD phase for ILM searchable_snapshot step.

@samxbr samxbr added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Apr 14, 2025
@samxbr samxbr requested a review from dakrone April 14, 2025 21:30
@samxbr samxbr marked this pull request as ready for review April 14, 2025 22:00
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Apr 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

dakrone
dakrone approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Sam

@samxbr samxbr merged commit 718315c into elastic:main Apr 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue Team:Data Management Meta label for data/management team v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samxbr @elasticsearchmachine @dakrone