Skip to content

update JWT realm docs to include at+jwt support #126841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

richard-dennehy
Copy link
Contributor

Update docs to mention at+jwt support introduced here

See also elastic/docs-content#1124

@richard-dennehy richard-dennehy added >docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team labels Apr 15, 2025
@richard-dennehy richard-dennehy requested a review from n1v0lg April 15, 2025 12:11
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v8.19.0 labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- optional nit

@@ -294,7 +294,7 @@ token.
as `HS256`. The algorithm must be in the realm's allow list.

`typ`::
(Optional, String) Indicates the token type, which must be `JWT`.
(Optional, String) Indicates the token type. For an ID token, this must be `JWT`; for access tokens, this must be `JWT` or `at+jwt`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unless its a pain because of asciidoc formatting, lets match the itemized format from: https://github.com/elastic/docs-content/pull/1124/files#diff-3761114bd79abf4acad1c5d598f9cbafc116580eeb95beeda3dc0f1466fdd5fcR221

@richard-dennehy richard-dennehy merged commit 556408e into elastic:8.x Apr 16, 2025
5 checks passed
@richard-dennehy richard-dennehy deleted the at+jwt-support-docs branch April 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Docs Meta label for docs team Team:Security Meta label for security team v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants