Skip to content

[DOCS] Update esql-lookup-join.md to mention index mode requirement #126901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

leemthompo
Copy link
Contributor

9.x for #126897

This PR updates the lookup join landing page, not the function docs

@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v9.0.0 labels Apr 16, 2025
@leemthompo leemthompo self-assigned this Apr 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 for the quick turnaround!

@@ -1,7 +1,7 @@
---
navigation_title: "Correlate data with LOOKUP JOIN"
mapped_pages:
- https://www.elastic.co/guide/en/elasticsearch/reference/current/esql-enrich-data.html
- https://www.elastic.co/guide/en/elasticsearch/reference/8.18/_lookup_join.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2x checking, is 8.18 what we want here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks yes this is metadata on the page if folks want to switch to the 8.18 version :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gets rendered liked this

Screenshot 2025-04-16 at 12 15 05

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 TIL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary as part of docs migration to new system

@leemthompo leemthompo merged commit 92148cf into main Apr 16, 2025
7 checks passed
@leemthompo leemthompo deleted the leemthompo-patch-4 branch April 16, 2025 10:15
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Apr 16, 2025
…lastic#126901)

*  Update esql-lookup-join.md to mention index mode requirement

* fix 8.x page mapping metadata
elasticsearchmachine pushed a commit that referenced this pull request Apr 16, 2025
…126901) (#126904)

*  Update esql-lookup-join.md to mention index mode requirement

* fix 8.x page mapping metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants