Skip to content

ES|QL: make telemetry more strict #126940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

ES|QL: make telemetry more strict #126940

merged 4 commits into from
Apr 17, 2025

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Apr 16, 2025 •
edited
Loading

When adding new commands, it's easy to miss the fact that they have to be added to the telemetry (phone-home).

This PR adds an explicit check so that a command has to be mapped or explicitly excluded, otherwise we'll throw an exception.

This also maps missing commands (LOOKUP JOIN, CHANGE POINT, INLINESTATS, RERANK, DEDUP, INSIST, FORK, RRF, COMPLETION)

TODO:

  • add tests to 60_usage.yml

@luigidellaquila luigidellaquila added auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.19.0 v9.0.1 v8.18.1 labels Apr 16, 2025
@luigidellaquila luigidellaquila marked this pull request as ready for review April 17, 2025 07:39
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila luigidellaquila requested a review from bpintea April 17, 2025 07:40
@luigidellaquila
Copy link
Contributor Author

@bpintea when we implemented TelemetryAware interface, I missed the fact that it only applied to APM telemetry and not to the phone-home stats, so we completely forgot to map the new commands, LOOKUP JOIN in particular.

This PR is mainly to avoid that we forget it again

@luigidellaquila luigidellaquila requested a review from astefan April 17, 2025 07:43
bpintea
bpintea approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Luigi!

@luigidellaquila luigidellaquila enabled auto-merge (squash) April 17, 2025 08:02
@luigidellaquila luigidellaquila merged commit 6b8c37e into elastic:main Apr 17, 2025
15 of 17 checks passed
@luigidellaquila luigidellaquila mentioned this pull request Apr 17, 2025
Merged
luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Apr 17, 2025
@luigidellaquila
ES|QL: make telemetry more strict (elastic#126940)
416ed4d
This was referenced Apr 17, 2025
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Apr 17, 2025
@luigidellaquila
ES|QL: make telemetry more strict (elastic#126940)
46847cf
luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Apr 17, 2025
@luigidellaquila
ES|QL: make telemetry more strict (elastic#126940)
57984d6
elasticsearchmachine pushed a commit that referenced this pull request Apr 17, 2025
@luigidellaquila
[9.0] ES|QL: make telemetry more strict (#126940) (#126983)
df820b8 
* ES|QL: make telemetry more strict (#126940)

* fix

* Fix tests
elasticsearchmachine pushed a commit that referenced this pull request Apr 17, 2025
@luigidellaquila
[8.18] ES|QL: make telemetry more strict (#126940) (#126980)
d53a324 
* ES|QL: make telemetry more strict (#126940)

* Fix compile

* Fix tests

* Fix test
elasticsearchmachine pushed a commit that referenced this pull request Apr 17, 2025
@luigidellaquila
[8.x] ES|QL: make telemetry more strict (#126940) (#126981)
150843f 
* ES|QL: make telemetry more strict (#126940)

* Fix compile

* Fix tests

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea approved these changes

@astefan astefan Awaiting requested review from astefan

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigidellaquila @elasticsearchmachine @bpintea