Skip to content

Temporarily bypass competitive iteration for filters aggregation #126956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

benwtrent
Copy link
Member

In certain conditions, using a query with filters aggregation can result in non-deterministic aggregation counts.

This is caused by how we handle the competitive iteration of the query and the filters aggregation.

This commit will temporarily bypass our competitive iteration for filters aggs.

related to: #126955

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

@nik9000 nik9000 enabled auto-merge (squash) April 16, 2025 20:10
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben, for a quick workaround

@wwang500 wwang500 added the cloud-deploy Publish cloud docker image for Cloud-First-Testing label Apr 16, 2025
@nik9000 nik9000 merged commit b1f7662 into elastic:main Apr 16, 2025
17 checks passed
julio-santana added a commit that referenced this pull request Apr 17, 2025
#126962)

* Temporarily bypass competitive iteration for filters aggregation (#126956)

* Bump versions after 9.0.0 release

* fix merge conflict

* Remove 8.16 from branches.json

* Bring version-bump related changes from main

* [bwc] Add bugfix3 project (#126880)

* Sync version bump changes from main again

---------

Co-authored-by: Benjamin Trent <[email protected]>
Co-authored-by: elasticsearchmachine <[email protected]>
Co-authored-by: elasticsearchmachine <[email protected]>
Co-authored-by: Brian Seeders <[email protected]>
This was referenced Apr 17, 2025
benwtrent added a commit that referenced this pull request Apr 23, 2025
I forgot to bypass the competitive iteration for the single bucket case when previously

closes: #127262

related: #126956
related: #126955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >bug cloud-deploy Publish cloud docker image for Cloud-First-Testing Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants