Support depthOffset in MD docs headings for nesting functions #126984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
leemthompo
approved these changes
Apr 17, 2025
leemthompo
reviewed
Apr 17, 2025
...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/FunctionInfo.java
Outdated
Show resolved
Hide resolved
|
Multi match changes LGTM. |
…expression/function/FunctionInfo.java Co-authored-by: Liam Thompson <[email protected]>
craigtaverner
force-pushed
the
esql_docs_depthOffset
branch
from
8d0cbb1 to
9a00419
Compare
💚 Backport successful
|
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Apr 19, 2025
…c#126984) While this change appears subtle at this point, I am using this in a later PR that adds a lot more spatial functions, where nesting them in related groups like this looks much better. The main impact of this is that the On this page navigator on the right panel of the docs will show the nesting Co-authored-by: Liam Thompson <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 19, 2025
… (#127092) While this change appears subtle at this point, I am using this in a later PR that adds a lot more spatial functions, where nesting them in related groups like this looks much better. The main impact of this is that the On this page navigator on the right panel of the docs will show the nesting Co-authored-by: Liam Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this change appears subtle at this point, I am using this in a later PR that adds a lot more spatial functions, where nesting them in related groups like this looks much better.
The main impact of this is that the
On this pagenavigator on the right panel of the docs will show the nesting: