Skip to content

ESQL: Keep DROP attributes when resolving field names #127009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 19, 2025
Merged

ESQL: Keep DROP attributes when resolving field names #127009

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1a8dadc
Keep attribute
kanoshiou Apr 17, 2025
424aff5
Add tests
kanoshiou Apr 17, 2025
8eca69d
Update docs/changelog/127009.yaml
kanoshiou Apr 17, 2025
093933c
Remove 126026 from `ALLOWED_ERRORS`
kanoshiou Apr 17, 2025
7e8c5ca
Fix bwc
kanoshiou Apr 17, 2025
0d32538
Merge branch 'refs/heads/main' into keep-drop-attributes-when-resolvi…
kanoshiou Apr 17, 2025
754daf3
Reformat code
kanoshiou Apr 18, 2025
ba798c2
Merge branch 'refs/heads/main' into keep-drop-attributes-when-resolvi…
kanoshiou Apr 18, 2025
de16422
Merge branch 'refs/heads/main' into keep-drop-attributes-when-resolvi…
kanoshiou Apr 23, 2025
16e50d0
Update tests
kanoshiou Apr 23, 2025
108b133
Merge branch 'refs/heads/main' into keep-drop-attributes-when-resolvi…
kanoshiou May 2, 2025
af9c70d
Slightly adjust the solution and add a couple of tests
astefan May 9, 2025
99802f1
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan May 9, 2025
6d80d58
Add capability to test
astefan May 9, 2025
faf0518
Merge branch 'main' into keep-drop-attributes-when-resolving-field-names
astefan May 9, 2025
60140ad
Merge branch 'main' into keep-drop-attributes-when-resolving-field-names
astefan May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove 126026 from ALLOWED_ERRORS
  • Loading branch information
@kanoshiou
kanoshiou committed Apr 17, 2025
commit 093933c05b910eec71cd0893c8452f6a90dd218a
1 change: 0 additions & 1 deletion ...ver/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
"token recognition error at: '``", // https://github.com/elastic/elasticsearch/issues/125870
"Unknown column \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/126026
"optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/116781
"No matches found for pattern", // https://github.com/elastic/elasticsearch/issues/126418
"The incoming YAML document exceeds the limit:" // still to investigate, but it seems to be specific to the test framework
);

Expand Down