Fix AsyncSearchActionIT tests #127010
Merged
Fix AsyncSearchActionIT tests #127010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed a spot here when moving this to delayed deserialization, we can leak pending batch results here on exceptions. closes elastic#126994 closes elastic#126995 closes elastic#126975 closes elastic#126999 closes elastic#127001 closes elastic#126974 closes elastic#127008
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
I'm wondering about something here - with this bug, the tests fail in 1% of cases. Can we make a test that would always fail for this bug? So that we could rely on CI to always catch it in time, not post-factum. |
|
@smalyshev it's hard to make it fail deterministically since it's such a small number of tests in this run and we aren't guaranteed to have a GC run before the test finishes. |
smalyshev
approved these changes
Apr 17, 2025
|
Thanks Stas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a spot here when moving this to delayed deserialization, we can leak pending batch results here on exceptions.
Just making this poll from a queue instead of nulling out in a list to keep it simple.
I'll look into a follow-up to clean up the horrible patterns used in QueryPhaseResultConsumer that keep bringing this kind of failure up over and over. Mutable collections like that are just painful to get right, this can be solved cleaner with our futures framework these days.
closes #126994
closes #126995
closes #126975
closes #126999
closes #127001
closes #126974
closes #127008