NOOP some transport versions #127037
Merged
NOOP some transport versions #127037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally released the `9_051_0_00` and `9_052_0_00` transport versions to serverless without their backing code. We can't take that back. It's live. You can't unbake the cake. That version of Elasticsearch will claim to be `9_052_0_00` but actually speak `9_050_0_00` code. To make main compatible with that version we're bumping all transport versions in main *past* those numbers. This is a forbidden action. You may not do this. I may not do this. It is not safe. But it is the only way to make the world whole again. In all seriousness, everything will be fine. It's against the rules but sometimes you have to break rules to put things right. We believe some serverless dev environments may break which is sad but it's worth it to bring everything back to sane land.
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally released the
9_051_0_00and9_052_0_00transport versions to serverless without their backing code. We can't take that back. It's live. You can't unbake the cake.That version of Elasticsearch will claim to be
9_052_0_00but actually speak9_050_0_00code. To make main compatible with that version we're bumping all transport versions in main past those numbers.This is a forbidden action. You may not do this. I may not do this. It is not safe. But it is the only way to make the world whole again.
In all seriousness, everything will be fine. It's against the rules but sometimes you have to break rules to put things right. We believe some serverless dev environments may break which is sad but it's worth it to bring everything back to sane land.