Skip to content

[Tests] Fix index compatibility checks for AArch64 #127052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

jozala
Copy link
Contributor

@jozala jozala commented Apr 18, 2025

This is required to follow the same logic as for filtering supported versions in BwC:

private List<Version> filterSupportedVersions(List<Version> wireCompat) {
Predicate<Version> supported = v -> true;
if (Architecture.current() == Architecture.AARCH64) {
final String version;
if (ElasticsearchDistribution.CURRENT_PLATFORM.equals(ElasticsearchDistribution.Platform.DARWIN)) {
version = "7.16.0";
} else {
version = "7.12.0"; // linux shipped earlier for aarch64
}
supported = v -> v.onOrAfter(version);
}
return wireCompat.stream().filter(supported).collect(Collectors.toList());
}

AArch64 distro wasn't supported before 7.16 on Mac and before 7.12 on Linux.

This fixes the failing test on CI for AArch64 OSes.

@jozala jozala added >non-issue >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure v8.18.1 v8.19.0 labels Apr 18, 2025
@jozala jozala requested a review from brianseeders April 18, 2025 10:14
@jozala jozala added the auto-backport Automatically create backport pull requests when merged label Apr 18, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Apr 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jozala jozala requested a review from a team April 18, 2025 11:02
Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!. I wonder how come we only have detected that? 🤔

@jozala
Copy link
Contributor Author

jozala commented May 5, 2025

Nice!. I wonder how come we only have detected that? 🤔

This test has been muted for a long time:
#98054

@jozala jozala merged commit 0861046 into elastic:8.19 May 5, 2025
15 checks passed
jozala added a commit to jozala/elasticsearch that referenced this pull request May 5, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.18.2 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants