Skip to content

[docs] Fix various syntax and rendering errors #127062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Fixes various syntax and rendering errors that might include:

  • Fixing broken images
  • Hardcoding book-level substitution values
  • Fixing incorrectly closed blocks (admonitions, tab sets, code blocks, dropdowns etc.)
  • Fixing poorly migrated complex tables
  • Fixing poorly migrated lists
  • Fixing poorly migrated tab sets
  • Removing inline text formatting from directive titles where they won't be rendered (for example, inline code formatting in dropdown titles)
  • Specifying if a version is trying to communicate if a feature was added, deprecated, or coming (for example, during migration deprecated:[8.15.0] became [8.15.0], which doesn't give any information about what happened in 8.15.0)
  • Fixing nested dropdowns / definition lists
  • Fixing poorly migrated footnotes
  • Updating references to prerelease 9.0.0 versions

@colleenmcginnis colleenmcginnis added >docs General docs changes Team:Docs Meta label for docs team documentation labels Apr 18, 2025
@colleenmcginnis colleenmcginnis requested a review from a team April 18, 2025 15:06
@colleenmcginnis colleenmcginnis self-assigned this Apr 18, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 18, 2025
@colleenmcginnis colleenmcginnis changed the title [docs] Fix syntax rendering errors [docs] Fix various syntax and rendering errors Apr 18, 2025
@colleenmcginnis colleenmcginnis marked this pull request as ready for review April 23, 2025 15:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@@ -34,7 +34,7 @@ The following numeric types are supported:
: A floating point number that is backed by a `long`, scaled by a fixed `double` scaling factor.

`unsigned_long`
: An unsigned 64-bit integer with a minimum value of 0 and a maximum value of `2`^`64`^`-1`.
: An unsigned 64-bit integer with a minimum value of 0 and a maximum value of `2^64 - 1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem with the superscripts is the pesky backticks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we change this? If yes, can you provide a suggestion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"should" is strong, just pointing out that the superscript syntax won't work when code formatted, not high priority but if you're scripting these changes just a point to note for future :)

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should either format it like this (all inside code like 2^64 - 1) or with no code (just 264 - 1). Which do you prefer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup fully agreed we should pick one, and I think inside code is good because folks often want numbers to be code formatted so they stand out against the surrounding text

If I was being idiosyncratic and operating in a vacuum I'd probably use no code proper superscripting but bold 😄

Screenshot 2025-04-25 at 10 10 21

@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v9.0.0 labels Apr 24, 2025
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked a few pages and looks good to me 👍

@leemthompo leemthompo merged commit 08552f1 into elastic:main Apr 24, 2025
6 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-syntax-rendering-errors branch April 24, 2025 15:57
@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Apr 24, 2025
* fix syntax and rendering errors

* clean up

* fix versions

* more clean up

* more fixes

* more fixes

* more fixes

(cherry picked from commit 08552f1)

# Conflicts:
#	docs/reference/elasticsearch/mapping-reference/dense-vector.md
#	docs/reference/elasticsearch/mapping-reference/semantic-text.md
elasticsearchmachine pushed a commit that referenced this pull request Apr 24, 2025
* fix syntax and rendering errors

* clean up

* fix versions

* more clean up

* more fixes

* more fixes

* more fixes

(cherry picked from commit 08552f1)

# Conflicts:
#	docs/reference/elasticsearch/mapping-reference/dense-vector.md
#	docs/reference/elasticsearch/mapping-reference/semantic-text.md

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes documentation external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants