Skip to content

ESQL: Unmute test #127065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 18, 2025

It was assuming a simpler execution model. This weakens the assertion to one that should always pass.

Closes #127046
Closes #127039
Closes #127090
Closes #127080

It was assuming a simpler execution model. This weakens the assertion to
one that should always pass.

Closes elastic#127046
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL v9.1.0 labels Apr 18, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsbauman
Copy link
Contributor

@nik9000 thanks for fixing this. Could you also unmute #127088 please? That one was initially assigned to Data Management but I reassigned it to Analytics.

@elasticsearchmachine elasticsearchmachine merged commit 5b351af into elastic:main Apr 21, 2025
17 checks passed
@nik9000 nik9000 deleted the esql_unmute_docs_yaml branch April 21, 2025 14:17
@nielsbauman
Copy link
Contributor

Ah, looks like my comment triggered the bot to merge the PR. It'll have to be unmuted in a follow-up PR.

@nik9000
Copy link
Member Author

nik9000 commented Apr 21, 2025

Ah, looks like my comment triggered the bot to merge the PR. It'll have to be unmuted in a follow-up PR.

Surprise!

@alex-spies
Copy link
Contributor

Follow-up with remaining unmutes: #127228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
5 participants