Skip to content

Revert semantic_text model registry changes #127075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kderusso
Copy link
Member

elastic/kibana#218497 flagged two PRs as potentially blockers due to test failures:

This PR reverts these changes if needed to unblock these test failures until they can be addressed.

@kderusso kderusso added >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.1.0 labels Apr 18, 2025
@kderusso kderusso requested review from jimczi and Mikep86 April 18, 2025 20:36
@kderusso kderusso marked this pull request as ready for review April 18, 2025 21:25
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

Copy link
Contributor

@julio-santana julio-santana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kderusso kderusso merged commit e280aa5 into elastic:main Apr 18, 2025
17 checks passed
viduni94 added a commit to elastic/kibana that referenced this pull request Apr 21, 2025
Closes #218497

## Summary

The summarize tests were skipped last week because they were failing and
blocking pipelines.

These tests have started to fail after the merge of
elastic/elasticsearch#126635
These changes were reverted last week in
elastic/elasticsearch#127075

Therefore, this PR unskips the tests.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 21, 2025
Closes elastic#218497

## Summary

The summarize tests were skipped last week because they were failing and
blocking pipelines.

These tests have started to fail after the merge of
elastic/elasticsearch#126635
These changes were reverted last week in
elastic/elasticsearch#127075

Therefore, this PR unskips the tests.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 766cd47)
kibanamachine added a commit to elastic/kibana that referenced this pull request Apr 21, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Obs AI Assistant] Unskip summarize tests
(#218728)](#218728)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-21T16:07:54Z","message":"[Obs
AI Assistant] Unskip summarize tests (#218728)\n\nCloses
https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe
summarize tests were skipped last week because they were failing
and\nblocking pipelines.\n\nThese tests have started to fail after the
merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese
changes were reverted last week
in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore,
this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Unskip summarize
tests","number":218728,"url":"https://github.com/elastic/kibana/pull/218728","mergeCommit":{"message":"[Obs
AI Assistant] Unskip summarize tests (#218728)\n\nCloses
https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe
summarize tests were skipped last week because they were failing
and\nblocking pipelines.\n\nThese tests have started to fail after the
merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese
changes were reverted last week
in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore,
this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218728","number":218728,"mergeCommit":{"message":"[Obs
AI Assistant] Unskip summarize tests (#218728)\n\nCloses
https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe
summarize tests were skipped last week because they were failing
and\nblocking pipelines.\n\nThese tests have started to fail after the
merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese
changes were reverted last week
in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore,
this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description
includes the appropriate Release Notes section,\nand the correct
`release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <[email protected]>
pgayvallet pushed a commit to pgayvallet/kibana that referenced this pull request Apr 22, 2025
Closes elastic#218497

## Summary

The summarize tests were skipped last week because they were failing and
blocking pipelines.

These tests have started to fail after the merge of
elastic/elasticsearch#126635
These changes were reverted last week in
elastic/elasticsearch#127075

Therefore, this PR unskips the tests.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Apr 22, 2025
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants