Skip to content

Replacing unsupported **Note** with [!Note] #127102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2025
Merged

Replacing unsupported **Note** with [!Note] #127102

merged 6 commits into from
May 5, 2025

Conversation

shahbazaamir
Copy link
Contributor

@shahbazaamir shahbazaamir commented Apr 20, 2025 •
edited
Loading

  • Have you signed the contributor license agreement? - yes
  • Have you followed the contributor guidelines? - yes
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Apr 20, 2025 •
edited
Loading

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.1.0 labels Apr 20, 2025
@gbanasiak gbanasiak added the :Delivery/Build Build or test infrastructure label Apr 28, 2025
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team and removed needs:triage Requires assignment of a team area label labels Apr 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby self-assigned this Apr 28, 2025
breskeby
breskeby approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@breskeby breskeby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shahbazaamir for this PR. I'm looking into having that merged later today

@shahbazaamir
Copy link
Contributor Author

Thank you @shahbazaamir for this PR. I'm looking into having that merged later today

My pleasure :)

@breskeby breskeby merged commit 80946ce into elastic:main May 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breskeby breskeby breskeby approved these changes

Assignees

@breskeby breskeby

Labels
:Delivery/Build Build or test infrastructure external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Delivery Meta label for Delivery team v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahbazaamir @elasticsearchmachine @breskeby @gbanasiak