Clean up PolicyManager and ScopeResolver tests #127115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>test
|
|
prdoyle
force-pushed
the
scope-resolver-tests
branch
from
b19289e to
915958e
Compare
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This was referenced Apr 23, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Apr 23, 2025
* Simplify PolicyManagerTests * Clean and simplify ScopeResolverTests
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Apr 23, 2025
* Simplify PolicyManagerTests * Clean and simplify ScopeResolverTests
|
8.x was blocked by this guy. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 23, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having separated the responsibilities of
PolicyManagerandScopeResolverin #126921, this PR now separates the testing responsibilities:ScopeResolverTestsensures that we determine the rightPolicyScopeinformation for a given classPolicyManagerTestsensures that we determine the right policy for a givenPolicyScopeThis has a dramatic simplifying effect on the tests.
I've also removed some redundant tests: we had some tests for one-module policies and others for two-module policies; but the two-module tests provide complete coverage on their own.