Skip to content

Update Elasticsearch main with snapshot version of Lucene #127125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2025

Conversation

julio-santana
Copy link
Contributor

This PR pulls in a snapshot version of Lucene with apache/lucene#14522 and apache/lucene#14523 - fixes to bugs in Lucene 10.2.0 along with a corresponding index version upgrade to Lucene version 10.2.1

@julio-santana julio-santana requested a review from a team as a code owner April 21, 2025 18:03
@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label labels Apr 21, 2025
@julio-santana julio-santana requested a review from a team April 21, 2025 18:04
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR are what I expected to see for such an update to Lucene. LGTM.

There are no format changes, so the index version seems a little unnecessary, but we typically update it for each Lucene change so it’s fine.

@julio-santana julio-santana self-assigned this Apr 21, 2025
@julio-santana julio-santana added the Team:Search Meta label for search team label Apr 21, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Apr 21, 2025
@julio-santana julio-santana added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 21, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 21, 2025
@julio-santana julio-santana added the :Search Relevance/Search Catch all for Search Relevance label Apr 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 21, 2025
@@ -160,6 +160,7 @@ private static Version parseUnchecked(String version) {
public static final IndexVersion SYNTHETIC_SOURCE_STORE_ARRAYS_NATIVELY_SCALED_FLOAT = def(9_020_0_00, Version.LUCENE_10_1_0);
public static final IndexVersion USE_LUCENE101_POSTINGS_FORMAT = def(9_021_0_00, Version.LUCENE_10_1_0);
public static final IndexVersion UPGRADE_TO_LUCENE_10_2_0 = def(9_022_00_0, Version.LUCENE_10_2_0);
public static final IndexVersion UPGRADE_TO_LUCENE_10_2_1 = def(9_023_00_0, parseUnchecked("10.2.1"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this constant be available in the snapshot version of Lucene?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to use the lucene constant.

@julio-santana julio-santana enabled auto-merge (squash) April 21, 2025 21:25
@julio-santana julio-santana merged commit 76f6006 into main Apr 21, 2025
17 of 18 checks passed
@julio-santana julio-santana deleted the lucene_snapshot_10_2_1 branch April 21, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants