-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update Elasticsearch main with snapshot version of Lucene #127125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR are what I expected to see for such an update to Lucene. LGTM.
There are no format changes, so the index version seems a little unnecessary, but we typically update it for each Lucene change so it’s fine.
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
@@ -160,6 +160,7 @@ private static Version parseUnchecked(String version) { | |||
public static final IndexVersion SYNTHETIC_SOURCE_STORE_ARRAYS_NATIVELY_SCALED_FLOAT = def(9_020_0_00, Version.LUCENE_10_1_0); | |||
public static final IndexVersion USE_LUCENE101_POSTINGS_FORMAT = def(9_021_0_00, Version.LUCENE_10_1_0); | |||
public static final IndexVersion UPGRADE_TO_LUCENE_10_2_0 = def(9_022_00_0, Version.LUCENE_10_2_0); | |||
public static final IndexVersion UPGRADE_TO_LUCENE_10_2_1 = def(9_023_00_0, parseUnchecked("10.2.1")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this constant be available in the snapshot version of Lucene?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated to use the lucene constant.
This PR pulls in a snapshot version of Lucene with apache/lucene#14522 and apache/lucene#14523 - fixes to bugs in Lucene 10.2.0 along with a corresponding index version upgrade to Lucene version 10.2.1