-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Improve listing of index mode options in docs #127155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-docs (Team:Docs) |
Thanks for catching this @ioanatia. I think there is also an indentation issue with nested definition lists here. It's a little finicky. I noodled on this locally, if you're happy with this output I can push a commit :) Note the example block and subsequent text are indented. I also added subheadings to clarify sub-sections and link to lookup join. |
@leemthompo feel free to push a commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR @ioanatia 🥇
💔 Backport failed
You can use sqren/backport to manually backport by running |
currently there is no visual break between the options for
index.mode
andindex.routing_partition_size
which is an index setting:checking to see if this change makes it better (looks good in my editor), but in the end it depends on how the docs are actually rendered.
EDIT: this is how it looks in the preview