Emit ordinal output block for values aggregate #127201
Merged
+255
−136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time-series aggregations rely heavily on the
values
aggregation for collecting grouping values. For example:is translated to:
We might change how these are executed later, but for now, we need to optimize the
values
aggregation forBytesRef
, especially in cases with low cardinality. This change emits ordinal blocks as the output of thevalues
aggregation, allowing the second aggregation to execute more efficiently. I will also open a PR to handle incoming ordinal blocks for thevalues
aggregation.