Fix CrossClusterEsqlRCS1EnrichUnavailableRemotesIT failing: assert only values and not their specific order #127270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawankartik-elastic
added
auto-backport
pawankartik-elastic
changed the title
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
smalyshev
approved these changes
Apr 23, 2025
💚 Backport successful
|
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Apr 23, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the assert statements check were checking for values, they were also asserting their order. This fix instead relies on
hasItemInArray()like we do in order tests.Fixes #126893.