Skip to content

Enable online prewarming for guice injection #127338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

andreidan
Copy link
Contributor

This hooks up the OnlinePrewarmingService implementation for guice injection (and enables us to lookup the implementation in ITs using the internalCluster.getInstance methods)

This hooks up the OnlinePrewarmingService implementation for guice
injection (and enables us to lookup the implementation in ITs using
the internalCluster.getInstance methods)
@andreidan andreidan added >non-issue :Search Foundations/Search Catch all for Search Foundations v9.1.0 labels Apr 24, 2025
@andreidan andreidan requested a review from a team as a code owner April 24, 2025 15:44
@andreidan andreidan requested a review from cbuescher April 24, 2025 15:44
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Apr 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@andreidan
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-2

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreidan andreidan merged commit 7f49c8a into elastic:main Apr 28, 2025
17 checks passed
benchaplin pushed a commit to benchaplin/elasticsearch that referenced this pull request Apr 28, 2025
This hooks up the OnlinePrewarmingService implementation for guice
injection (and enables us to lookup the implementation in ITs using
the internalCluster.getInstance methods)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants