Skip to content

Propagate file settings health info to the health node #127397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 5, 2025
Merged

Propagate file settings health info to the health node #127397

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b0d718e
Initial testHealthIndicator that fails
prdoyle Apr 23, 2025
32a7f7d
Refactor: FileSettingsHealthInfo record
prdoyle Apr 23, 2025
458a9b3
Propagate file settings health indicator to health node
prdoyle Apr 25, 2025
9339c3a
ensureStableCluster
prdoyle Apr 25, 2025
936813b
Try to induce a failure from returning node-local info
prdoyle Apr 28, 2025
4bee8d8
Remove redundant node from client() call
prdoyle Apr 29, 2025
e8c2a42
Use local node ID in UpdateHealthInfoCacheAction.Request
prdoyle Apr 29, 2025
411489f
Move logger to top
prdoyle Apr 29, 2025
434933d
Test node-local health on master and health nodes
prdoyle Apr 29, 2025
209902d
Fix calculate to use the given info
prdoyle Apr 29, 2025
e2c05f7
mutateFileSettingsHealthInfo
prdoyle Apr 29, 2025
bd5fed8
Test status from local current info
prdoyle Apr 29, 2025
4f6102b
FileSettingsHealthTracker
prdoyle Apr 30, 2025
12d7244
Spruce up HealthInfoTests
prdoyle Apr 30, 2025
095f377
spotless
prdoyle Apr 30, 2025
484d85f
randomNonNegativeLong
prdoyle Apr 30, 2025
203aad0
Merge remote-tracking branch 'upstream/main' into health
prdoyle Apr 30, 2025
a91b807
Rename variable
prdoyle Apr 30, 2025
696235b
Address Niels' comments
prdoyle Apr 30, 2025
6598e1f
Test one- and two-node clusters
prdoyle Apr 30, 2025
23fc675
Merge remote-tracking branch 'origin/health' into health
prdoyle Apr 30, 2025
07b2d8b
[CI] Auto commit changes from spotless
elasticsearchmachine Apr 30, 2025
ce015e7
Ensure there's a master node
prdoyle Apr 30, 2025
4e0978e
Merge branch 'main' into health
prdoyle Apr 30, 2025
debbf90
setBootstrapMasterNodeIndex
prdoyle Apr 30, 2025
98b7506
Merge branch 'main' into health
prdoyle May 5, 2025
e2cfbd7
Merge branch 'main' into health
prdoyle May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
randomNonNegativeLong
  • Loading branch information
@prdoyle
prdoyle committed Apr 30, 2025
commit 484d85f014857d95595e172c9bec73085a74e3ef
2 changes: 1 addition & 1 deletion server/src/test/java/org/elasticsearch/health/node/HealthInfoTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public static RepositoriesHealthInfo randomRepoHealthInfo() {
}

private static FileSettingsHealthInfo mutateFileSettingsHealthInfo(FileSettingsHealthInfo original) {
long changeCount = randomValueOtherThan(original.changeCount(), ESTestCase::randomLong);
long changeCount = randomValueOtherThan(original.changeCount(), ESTestCase::randomNonNegativeLong);
long failureStreak = randomLongBetween(0, changeCount);
String mostRecentFailure;
if (failureStreak == 0) {
Expand Down