Don't emit deprecation issue for compatible date format patterns #127418
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.18.1
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @mark-vieira, I've created a changelog YAML for you. |
prdoyle
approved these changes
Apr 25, 2025
docs/changelog/127418.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 127418 | |||
| summary: Don't issue deprecation issue for compatible date format patterns | |||
There was a problem hiding this comment.
"emit deprecation warning" perhaps?
There was a problem hiding this comment.
Agreed, "emit" is better.
mark-vieira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #124597 which fixes a bug where we could return a false positive deprecation issue for certain valid date format patterns. We now ignore fields if the date mapping pattern is one of those in
FormatNames.