Skip to content

Fix bug in PushQueriesIT #127421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

limotova
Copy link
Contributor

@limotova limotova commented Apr 26, 2025

When the length of the String value is 0, test cases get
stuck in an infinite loop trying to select a different random
String with length 0. This commit changes it to select a String with
length 1 in this case.

When the length of the String `value` is 0, test cases get
stuck in an infinite loop trying to select a different random
String with length 0.
@limotova limotova requested a review from nik9000 April 26, 2025 01:18
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels Apr 26, 2025
@limotova limotova added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label v9.1.0 labels Apr 26, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@limotova limotova merged commit 16e55d4 into elastic:main Apr 26, 2025
17 checks passed
@limotova limotova deleted the random-value-other-than-bug-fix branch April 26, 2025 02:59
benchaplin pushed a commit to benchaplin/elasticsearch that referenced this pull request Apr 28, 2025
When the length of the String `value` is 0, test cases get
stuck in an infinite loop trying to select a different random
String with length 0. This commit changes it to select a String with
length 1 in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants