Remove ChannelType.Client #127432
Open
Remove ChannelType.Client #127432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no usage of a client channel anywhere in prod code. -> remove any notion of a client channel and replace the now irrelevant enum with a boolean to simplify things. Also, cleanup handling of the max header length to make that more obvious and remove the indirection to a `ByteSizeValue` that really just wastes CPU cache and hides the 2G maximum default (however reasonable that number may be).
original-brownbear
added
>non-issue
:Core/Infra/Transport API
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no usage of a client channel anywhere in prod code. -> remove any notion of a client channel and replace the now irrelevant enum with a boolean to simplify things.
Also, cleanup handling of the max header length to make that more obvious and remove the indirection to a
ByteSizeValuethat really just wastes CPU cache and hides the 2G maximum default (however reasonable that number may be).