WIP: Release transport messages incrementally while reading them #127435
+187
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a few small steps left to clean this up but even in this form this solution essentially up to halves the heap used for handling large bulk shard requests on non-coordinating data nodes (this is just one example, there's a couple spots where this saves a lot of memory). Also, this could be extended to be a little smarter around compression easily, allowing for potential order of magnitude savings around indexing if we lazy deserialize individual docs or play similar tricks.
original-brownbear
added
>non-issue
WIP
:Distributed Coordination/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is still WIP but not too much work left actually.
That said ... even in this form the solution essentially up to halves the heap used for
handling large bulk shard requests on non-coordinating data nodes (this is
just one example, there's a couple spots where this saves a lot of memory).
Also, this could be extended to be a little smarter around compression easily, allowing
for potential order of magnitude savings around indexing if we lazy deserialize
individual docs or play similar tricks.