Fix UploadPartCopy source handling
#127442
Merged
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leading `/` on the `x-amz-copy-source` header is optional; SDKv1 includes it but SDKv2 does not. Today we handle its omission when handling a `CopyObject` request but we must do the same for the `UploadPartCopy` path. Closes elastic#127436
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
nicktindall
added
auto-backport
|
I notice the 8.19 label on this PR, but I'll leave it as is for now, but if there's something you'd like me to backport I'm happy to have a go. |
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 28, 2025
The leading `/` on the `x-amz-copy-source` header is optional; SDKv1 includes it but SDKv2 does not. Today we handle its omission when handling a `CopyObject` request but we must do the same for the `UploadPartCopy` path. Closes elastic#127436
DaveCTurner
deleted the
2025/04/27/127436-S3RepositoryAnalysisRestIT-testRepositoryAnalysis
branch
|
Ah yeah good point we don't copy objects in 8.19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading
/on thex-amz-copy-sourceheader is optional; SDKv1includes it but SDKv2 does not. Today we handle its omission when
handling a
CopyObjectrequest but we must do the same for theUploadPartCopypath.Closes #127436