Enable FAILURE_STORE feature flag for LogsIndexModeFullClusterRestartIT #127480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samxbr
added
>test-failure
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
samxbr
added
>test
nielsbauman
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
LGTM, thanks @samxbr!
I think we should backport this to more branches. I see some failures on main as well. And since the failure occurs during the upgrade from 8.17 to 8.18, I think we should backport to 8.19 and maybe even 8.18 to be sure.
I think you should be able to backport "forward' (i.e. by keeping the PR as-is and adding the auto-backport and 9.1.0 labels), but you can also change the target branch of the PR and rebase/cherry-pick the commit.
samxbr
added
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
samxbr
added a commit
to samxbr/elasticsearch
that referenced
this pull request
Apr 29, 2025
…IT (elastic#127480) (cherry picked from commit 71a6c7f) # Conflicts: # muted-tests.yml
samxbr
added a commit
to samxbr/elasticsearch
that referenced
this pull request
Apr 29, 2025
…IT (elastic#127480) (cherry picked from commit 71a6c7f) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
samxbr
added a commit
to samxbr/elasticsearch
that referenced
this pull request
Apr 29, 2025
…IT (elastic#127480) (cherry picked from commit 71a6c7f) # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was failing due to unable to parse failure store template, this enables the failure store feature flag for the test cluster.
Closes #126967