Release AggregationContext more eagerly #127484
Merged
+22
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to drag a reference to this thing around until the query result is fully release. Track it via a future (so it's unlinked on release) and release it as soon as we set the aggregations. Only release on aggs release and ref-counting to zero as a backup.
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Thanks Nhat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to drag a reference to this thing around until the query result is fully released. Track it via a future (so it's unlinked on release and just in general this makes for a much much safer pattern) and release it as soon as we set the aggregations. Only release on aggs release and ref-counting to zero as a backup.
Also, make it clear in naming and interfaces that this is not about a general purpose releasable tracking on the query result.