Skip to content

[WIP] Generate a test dependencies file to support unit tests in entitlements #127486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Apr 28, 2025

Example file output:

{
    "name": "lang-painless",
    "locations": [
        {
            "class": "Location.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/objectweb/asm/tree/analysis/Analyzer.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/objectweb/asm/AnnotationVisitor.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/antlr/v4/runtime/ANTLRErrorListener.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/objectweb/asm/tree/AbstractInsnNode.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/objectweb/asm/util/ASMifier.class",
            "module": "module-goes-here"
        },
        {
            "class": "org/objectweb/asm/commons/AdviceAdapter.class",
            "module": "module-goes-here"
        }
    ]
}

@jdconrad jdconrad requested a review from a team as a code owner April 28, 2025 22:46
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 28, 2025
@prdoyle
Copy link
Contributor

prdoyle commented May 5, 2025

We could reduce redundancy by mapping just package names to modules, instead of every individual class. That should make the file much smaller.

@prdoyle
Copy link
Contributor

prdoyle commented May 5, 2025

Jack pointed out that this already has just one entry per jar/directory.

In that case, I wonder if the structure should include that jar/directory info, if only for troubleshooting. Even if we don't need it to make our use case work, it could be easier for humans if the jar/directory is present in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants