-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Better behavior around ignore_missing when databases aren't available #127520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
and (formatting nit) don't have a period at the end of the message either
to be more in line with the data-available behavior -- that is, respect ignore_missing and throw an exception on an invalid source field.
See especially #87345 (comment) |
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @joegallo, I've created a changelog YAML for you. |
Per the description on #87345, a good test for this behavior is:
Without this PR, the result of this is (note the
But with this PR, the result is (note the lack of
|
Can you also add a blurb to the docs that clarifies the behavior of |
Closes #87345
The documentation for
ignore_missing
says:But if the database isn't available, then we unconditionally add tags to the document regardless of the value of the
ignore_missing
configuration, which doesn't seem correct.This PR aligns the behavior in the database-unavailable case to better match the behavior in the database-available case (and, by extension, to better match the docs).