ESQL: Consider inlinestats when having field_caps check for field names #127564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field_names_for_inlinestats_fix
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @astefan, I've created a changelog YAML for you. |
astefan
commented
Apr 30, 2025
| @@ -360,14 +362,14 @@ FROM airports | |||
| | LIMIT 3 | |||
| ; | |||
|
|
|||
| abbrev:keyword | city:keyword | region:text | "COUNT(*)":long | |||
There was a problem hiding this comment.
Unrelated to this PR, but to previous work.
astefan
commented
Apr 30, 2025
| @@ -127,7 +127,7 @@ protected void shouldSkipTest(String testName) throws IOException { | |||
| assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS.capabilityName())); | |||
| assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V2.capabilityName())); | |||
| assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_PLANNING_V1.capabilityName())); | |||
| assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V5.capabilityName())); | |||
| assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V7.capabilityName())); | |||
There was a problem hiding this comment.
V7 because I am trying to work on multiple separate issues. V6 should come from #127383
astefan
added
auto-backport
|
Hi @astefan, I've updated the changelog YAML for you. |
…astefan/elasticsearch into field_names_for_inlinestats_fix
…field_names_for_inlinestats_fix
|
Hi @astefan, I've updated the changelog YAML for you. |
…astefan/elasticsearch into field_names_for_inlinestats_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregate inside an inlinestats is "interfering" with the way field names are collected for field_caps requests. This made simple queries like
from test | inlinestats max(whatever) by groupto not return all fields fromtest, but to limit the resulting columns towhateverandgroup.inlinestats' purpose is to add columns to an already existent set of columns, which implies that this command has to be "transparent" to any wider collection of field names.Fixes #127236