Skip to content

ESQL: Apply precommit plugins to qa #127580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 30, 2025

We're not properly applying the precommit plugins the more modern qa projects. We'll likely apply it globally soon, but for now this applies it to all of ESQL's qa projects.

We're not properly applying the precommit plugins the more modern qa
projects. We'll likely apply it globally soon, but for now this applies
it to all of ESQL's qa projects.
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.1.0 labels Apr 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 30, 2025
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Nik!

@nik9000
Copy link
Member Author

nik9000 commented May 1, 2025

bwc tests passed but didn't report. merging.

@nik9000 nik9000 merged commit 42964d0 into elastic:main May 1, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants