Remove Security manager bootstrap #127590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furthing cleanup of the now unused security manager, this commit removes the bootstrap Security class that setup SecurityManager.
rjernst
added
>refactoring
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
approved these changes
May 1, 2025
| @@ -134,20 +131,6 @@ private static Bootstrap initPhase1() { | |||
| final boolean useEntitlements = true; | |||
There was a problem hiding this comment.
As far as I can tell this is initialized to true and then never modified. Can we get rid of this?
There was a problem hiding this comment.
Yes, I plan to do that in a followup, there are some other things using it.
| @@ -245,61 +228,47 @@ private static void initPhase2(Bootstrap bootstrap) throws IOException { | |||
|
|
|||
| final PluginsLoader pluginsLoader; | |||
|
|
|||
| if (bootstrap.useEntitlements()) { | |||
There was a problem hiding this comment.
We also have a useEntitlements() check in initPhase3(), can that be removed as well? In fact, can we remove Bootstrap.useEntitlements() entirely now?
There was a problem hiding this comment.
Actually, I'll remove that in a followup as well.
💚 Backport successful
|
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 1, 2025
Furthing cleanup of the now unused security manager, this commit removes the bootstrap Security class that setup SecurityManager.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthing cleanup of the now unused security manager, this commit removes the bootstrap Security class that setup SecurityManager.