ESQL: Allow the data type of null in filters #127618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow the data type of `null` in filters
This PR fixes elastic#119950 where an `IN` query includes `NULL` values with non-NULL `DataType` appearing within the query range. An expression is considered `NULL` when its `DataType` is `NULL` or it is a `Literal` with a value of `null`.
nik9000
commented
May 1, 2025
| @@ -307,11 +307,11 @@ public void testEmptyProjectionInStat() { | |||
|
|
|||
| /** | |||
| * Expects | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
I don't really know how these landed here to be honest.
There was a problem hiding this comment.
I don't believe I really made a change to this file. I'm going to revert it.
|
Note that some of this PR was accidentally backported as part of another change. Either way, this gets the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports two PRs by @kanoshiou:
nullin filters #118324: ESQL: Allow filter null in ESQL.Closes #116351
NULLhandling inINclause #125832: ESQL: Fix NULL handling in IN clauseThis PR fixes #119950 where an IN query includes NULL values with non-NULL DataType appearing within the query range. An expression is considered NULL when its DataType is NULL or it is a Literal with a value of null.