Add testcluster node log location to gradle run error message #127665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster node fails to come up. When `./gradlew run` fails, we would frequently need to see the node's log (stored elsewhere on disk) to learn what went wrong, but it is common expectation that errors would show up in console with other gradle output. This can lead to a frustrating developer experience, so we should point to the log location for debugging next steps. For the case of a cluster, the log message points to the log file of the first node. Hopefully, that is enough of a hint and the developer can pursue the logs of other nodes as needed.
elasticsearchmachine
added
needs:triage
|
Pinging @elastic/es-delivery (Team:Delivery) |
elasticsearchmachine
removed
the
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the failure message emitted to console when a test cluster node fails to come up.
When
./gradlew runfails, we would frequently need to peruse the node's logs (stored elsewhere on disk) to learn what went wrong, but it is reasonable expectation that errors would show up in console with other gradle output. This confusion can lead to a frustrating developer experience, so we should point to the log location for debugging next steps.For the case of a cluster, the log message points to the log file of the first node. Hopefully, that is enough of a hint and the developer can pursue the logs of other nodes as needed.