Cleanup ElasticsearchException a little #127713
Merged
+52
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looked into this logic a bit since I suspect it of causing some OOMs potentially. We should probably be using chunked writing for these in REST responses, but for now a couple smaller cleanups and savings only.
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Thanks Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked into this logic a bit since I suspect it of causing some OOMs potentially.
We should probably be using chunked writing for these in REST responses, but for now a couple smaller cleanups and savings in here. Maybe a sometimes serious win that protects us via avoiding a full + redundant copy in
toStringthough :) and it rarely hurts moving away from the builder on modern Java.