Skip to content

ES|QL: enable EXPLAIN (snapshot only) #129526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 23, 2025
Merged

ES|QL: enable EXPLAIN (snapshot only) #129526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
453ad04
ES|QL: enable EXPLAIN (snapshot only)
luigidellaquila Jun 17, 2025
ffbe3fd
Warnings
luigidellaquila Jun 17, 2025
ce0279b
Fix test
luigidellaquila Jun 17, 2025
d3503a3
Fix test
luigidellaquila Jun 17, 2025
996cb45
Merge branch 'main' into esql/explain
luigidellaquila Jun 17, 2025
8b7e234
Use LP RP instead
luigidellaquila Jun 17, 2025
936d10c
Merge branch 'main' into esql/explain
luigidellaquila Jun 17, 2025
448ebc4
dev mode only
luigidellaquila Jun 17, 2025
080e82e
Fix FROM
luigidellaquila Jun 17, 2025
93354e9
Merge branch 'main' into esql/explain
luigidellaquila Jun 17, 2025
ef8fe18
Make it type+plan
luigidellaquila Jun 18, 2025
ff436ec
Merge branch 'main' into esql/explain
luigidellaquila Jun 19, 2025
83a54d1
[CI] Auto commit changes from spotless
elasticsearchmachine Jun 19, 2025
1c5c3fe
Merge branch 'main' into esql/explain
luigidellaquila Jun 19, 2025
ab8ea09
Merge remote-tracking branch 'luigidellaquila/esql/explain' into esql…
luigidellaquila Jun 19, 2025
f794ef0
Merge branch 'main' into esql/explain
luigidellaquila Jun 19, 2025
82e48f4
Merge branch 'main' into esql/explain
luigidellaquila Jun 20, 2025
83a1a96
Fix output
luigidellaquila Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix FROM
  • Loading branch information
@luigidellaquila
luigidellaquila committed Jun 17, 2025
commit 080e82e92a031d700f8be003c5dbf292c5d21322
3 changes: 3 additions & 0 deletions x-pack/plugin/esql/src/main/antlr/lexer/From.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ FROM_COMMA : COMMA -> type(COMMA);
FROM_ASSIGN : ASSIGN -> type(ASSIGN);
METADATA : 'metadata';

// we need this for EXPLAIN
FROM_RP : RP -> type(RP), popMode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this RP is missing from some modes:

Now, JOIN technically would fail anyway, as the "ON" token changes to expression mode, so the question is if we want it to fail at lexer or parser level (?).
My guess is that a query like EXPLAIN (FROM index | LOOKUP JOIN lookup) would fail in different ways depending on this, but I'm not sure of which error we usually prefer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My actual concern is that every time we add a new command we'll have to do all this push/pop dance, but that's a broader topic...
About the error message, I'm not sure either


// in 8.14 ` were not allowed
// this has been relaxed in 8.15 since " is used for quoting
fragment UNQUOTED_SOURCE_PART
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseLexer.interp
View file
Open in desktop

Large diffs are not rendered by default.

Loading