Skip to content

ES-11372: Add project ID to key for geoip cache #129572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PeteGillinElastic
Copy link
Member

In this change, the lazy loader passes in the default project ID. That will be fixed in a later PR.

@PeteGillinElastic PeteGillinElastic added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Jun 17, 2025
In this change, the lazy loader passes in the default project ID. That
will be fixed in a later PR.
@PeteGillinElastic PeteGillinElastic force-pushed the ES-11372-geoip-cache-project-in-key branch from 4b72b95 to 206242e Compare June 17, 2025 16:08
@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review June 17, 2025 17:15
@PeteGillinElastic PeteGillinElastic requested a review from samxbr June 17, 2025 17:15
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jun 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeteGillinElastic PeteGillinElastic merged commit c4249a8 into elastic:main Jun 18, 2025
27 checks passed
@PeteGillinElastic PeteGillinElastic deleted the ES-11372-geoip-cache-project-in-key branch June 18, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue Team:Data Management Meta label for data/management team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants